Re: [PATCH 1/2] driver: add PPI support in tpm driver

From
Kent Yoder <hidden>
Date
2012-06-12 18:57:36
Also in
lkml
Reply to
Zhang, Xiaoyan, 2012-05-23
Hi Xiaoyan,

On Tue, May 22, 2012 at 10:34 PM, Zhang, Xiaoyan
[off-list ref] wrote:
From: Xiaoyan Zhang <redacted>

The Physical Presence Interface enables the OS and the BIOS to cooperate
and provides a simple and straightforward platform user experience for
administering the TPM without sacrificing security.

Signed-off-by: Xiaoyan Zhang <redacted>
---
 drivers/char/tpm/tpm.c |  462 ++++++++++++++++++++++++++++++++++++++++++++++++
 drivers/char/tpm/tpm.h |   18 ++
 2 files changed, 480 insertions(+), 0 deletions(-)
  This code looks clean - my only suggestion would be to add an #ifdef
CONFIG_ACPI around it so it compiles out on ppc.

Kent

-- 
IBM LTC Security
Thread (3 messages) 3 messages, 3 authors, last reply 2012-06-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help