Re: [PATCH v3] introduce sys_syncfs to sync a single file system

On Mon, March 14, 2011 02:37, Theodore Tso wrote:

On Mar 13, 2011, at 9:31 PM, Indan Zupancic wrote:

quoted

The new syscall works on only one fd too. The behaviour of the proposed
syncfs and an extended sync_file_range is exactly the same.

No, it's quite different.   One syncs the entire file system; sync_file_range
requests that the pages associated with a file be pushed to disk --- it says
nothing about the metadata associated with the file.

You missed the part where a new flag for sync_file_range would be added that
does sync the whole file system.

I'm in favor of the new sys_syncfs system call.

Care to define its behaviour? Does it wait till all data is written out,
does it flush disk caches, what if new data is written to the fs while
a sync is going on, etc.

Greetings,

Indan