Re: [PATCH v2 2/5] firmware: Basic dmi-sysfs support

From
Tony Luck <tony.luck@intel.com>
Date
2011-02-23 19:46:05
Also in
lkml
Reply to
Mike Waychison, 2011-02-23
On Tue, Feb 22, 2011 at 5:53 PM, Mike Waychison [off-list ref] wrote:
quoted hunk ↗ jump to hunk
+static void __init dmi_sysfs_register_handle(const struct dmi_header *dh,
+                                            void *_ret)
+{
I'm seeing some unaligned references from this function
on ia64.  Code is loading a 2-byte value from an odd
address. We are dereferencing "dh", so looking at the
dmi_header definition, I'd have thought that we must
be touching dh->handle:

struct dmi_header {
        u8 type;
        u8 length;
        u16 handle;
};

I don't see any code in this function that does this,
so I assume there is some inlining or macro stuff
happening.

-Tony
Thread (14 messages) 14 messages, 3 authors, last reply 2011-02-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help