Re: [PATCH v2 3/5]add metadata_readahead ioctl in vfs

From
Arnd Bergmann <hidden>
Date
2011-01-05 09:09:20
Also in
linux-fsdevel
Reply to
Shaohua Li, 2011-01-05
On Wednesday 05 January 2011 03:11:36 Shaohua Li wrote:
quoted
Did you notice the comment above the function? ;-)

You should really add the new ioctls to compat_sys_ioctl, not
to the COMPATIBLE_IOCTL() list, in order to make the behavior
consistent between 32 and 64 bit user space. The main difference
is that all ioctl commands that are hardcoded in the functions
get called before trying to call the file system specific
.ioctl method.
Thanks, fixed them.
The patch you posted still uses COMPATIBLE_IOCTL. Wrong patch?

	Arnd
  






  

    
      Thread (5 messages)
      
        5 messages,
        4 authors,
        last reply 2011-01-07
      
    
    
      
      
      
    
  

  

  
  




    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread / next series-diff position

          
kprevious message in thread / previous series-diff position

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help