Re: [PATCH V9 08/13] posix clocks: cleanup the CLOCK_DISPTACH macro
From: Thomas Gleixner <hidden>
Date: 2011-01-13 17:04:18
Also in:
lkml, netdev
On Thu, 13 Jan 2011, Richard Cochran wrote:
int posix_cpu_clock_getres(const clockid_t which_clock, struct timespec *ts); int posix_cpu_clock_get(const clockid_t which_clock, struct timespec *ts); -int posix_cpu_clock_set(const clockid_t which_clock, const struct timespec *ts); +int posix_cpu_clock_set(const clockid_t which_clock, struct timespec *ts);
Shouldn't we change the clock_set function to have *ts const in all places ?
quoted hunk ↗ jump to hunk
static int posix_ktime_get_ts(clockid_t which_clock, struct timespec *tp)@@ -279,12 +230,29 @@ static __init int init_posix_timers(void) { struct k_clock clock_realtime = { .clock_getres = hrtimer_get_res, + /* defaults: */ + .clock_adj = common_clock_adj, + .clock_get = common_clock_get, + .clock_set = common_clock_set, + .nsleep = common_nsleep, + .nsleep_restart = common_nsleep_restart, + .timer_create = common_timer_create, + .timer_del = common_timer_del, + .timer_get = common_timer_get, + .timer_set = common_timer_set, }; struct k_clock clock_monotonic = { .clock_getres = hrtimer_get_res, .clock_get = posix_ktime_get_ts, .clock_set = do_posix_clock_nosettime, .clock_adj = do_posix_clock_noadjtime, + /* defaults: */ + .nsleep = common_nsleep, + .nsleep_restart = common_nsleep_restart, + .timer_create = common_timer_create, + .timer_del = common_timer_del, + .timer_get = common_timer_get, + .timer_set = common_timer_set, }; struct k_clock clock_monotonic_raw = { .clock_getres = hrtimer_get_res,@@ -293,6 +261,11 @@ static __init int init_posix_timers(void) .clock_adj = do_posix_clock_noadjtime, .timer_create = no_timer_create, .nsleep = no_nsleep, + /* defaults: */ + .nsleep_restart = common_nsleep_restart, + .timer_del = common_timer_del, + .timer_get = common_timer_get, + .timer_set = common_timer_set,
Hmm, we do not need to set functional entries for clocks which neither
implement timer_create nor nsleep.
Otherwise I really like the outcome. :)
Thanks for your patience !
tglx