Re: [PATCH v2 17/23] kmsg_dumper: Introduce a new 'SOFT' dump reason
From: KOSAKI Motohiro <hidden>
Date: 2010-11-09 05:49:19
Also in:
lkml
Hi
It is a useful to be able to exercise kmsg_dumper implementations without requiring a kernel oops or panic. This commit adds a new reason called KMSG_DUMP_SOFT, which signifies that the system isn't really going down. This logic is used in a later commit that introduces the netoops driver. Signed-off-by: Mike Waychison <redacted> --- It is also possible that we not introduce KMSG_DUMP_SOFT, and simply overload the existing KMSG_DUMP_OOPS reason, but I figured that this would be cleaner. TODO: Make sure mtdoops and ramoops do something useful with this flag?
Yes. If userland explicitly want to log, we have no reason to refuse it. :) But, I don't think KMSG_DUMP_SOFT is good name because _SOFT don't explain anything.
quoted hunk ↗ jump to hunk
--- include/linux/kmsg_dump.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)diff --git a/include/linux/kmsg_dump.h b/include/linux/kmsg_dump.h index a229acc..0abc2d7 100644 --- a/include/linux/kmsg_dump.h +++ b/include/linux/kmsg_dump.h@@ -20,6 +20,7 @@ enum kmsg_dump_reason { KMSG_DUMP_OOPS, KMSG_DUMP_PANIC, KMSG_DUMP_KEXEC, + KMSG_DUMP_SOFT, }; /** --To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/