Thread (15 messages) 15 messages, 6 authors, 2008-11-21

Re: [take 3] Use pid in inotify events.

flat view

From: Evgeniy Polyakov <hidden>
Date: 2008-11-21 15:09:05
Also in: lkml

Possibly related (same subject, not in this thread)

On Fri, Nov 21, 2008 at 03:57:09PM +0100, Pavel Machek (pavel-AlSwsSmVLrQ@public.gmane.org) wrote:
quoted
John & I intentionally did not add the pid field when writing inotify
for reasons of security and questionable need. It also stinks to have
to add a pid field to the event structure if that field is seldom
used.
...plus the permission check was quite strange. We don't normally try
to hide PIDs, and 'equal uid' is very non-standard test. can_ptrace()
is normally used for such stuff...
That's what Reobert suggested as a security measure. Expect this
decision will not be described in details, why it is good or bad.

I'm prefectly fine without this check either.

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help