[PATCH] alpha: osf_sys: reduce kernel log spamming on invalid osf_mount call typenr

Subsystems: alpha port, the rest

STALE1253d

2 messages, 2 authors, 2023-02-26 · open the first message on its own page

[PATCH] alpha: osf_sys: reduce kernel log spamming on invalid osf_mount call typenr

From: Colin Ian King <hidden>
Date: 2021-12-13 18:56:33

Calling the osf_mount system call with an invalid typenr value will
spam the kernel log with error messages. Reduce the spamming by making
it a ratelimited printk.  Issue found when exercising with the stress-ng
enosys system call stressor.

Signed-off-by: Colin Ian King <redacted>
---
 arch/alpha/kernel/osf_sys.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/alpha/kernel/osf_sys.c b/arch/alpha/kernel/osf_sys.c
index 8bbeebb73cf0..2367a385d726 100644
--- a/arch/alpha/kernel/osf_sys.c
+++ b/arch/alpha/kernel/osf_sys.c
@@ -521,7 +521,7 @@ SYSCALL_DEFINE4(osf_mount, unsigned long, typenr, const char __user *, path,
 		break;
 	default:
 		retval = -EINVAL;
-		printk("osf_mount(%ld, %x)\n", typenr, flag);
+		printk_ratelimited("osf_mount(%ld, %x)\n", typenr, flag);
 	}
 
 	return retval;
-- 
2.33.1

Re: [PATCH] alpha: osf_sys: reduce kernel log spamming on invalid osf_mount call typenr

From: Matt Turner <mattst88@gmail.com>
Date: 2023-02-26 02:09:20

On Mon, Dec 13, 2021 at 10:58 PM Colin Ian King [off-list ref] wrote:
quoted hunk
Calling the osf_mount system call with an invalid typenr value will
spam the kernel log with error messages. Reduce the spamming by making
it a ratelimited printk.  Issue found when exercising with the stress-ng
enosys system call stressor.

Signed-off-by: Colin Ian King <redacted>
---
 arch/alpha/kernel/osf_sys.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/alpha/kernel/osf_sys.c b/arch/alpha/kernel/osf_sys.c
index 8bbeebb73cf0..2367a385d726 100644
--- a/arch/alpha/kernel/osf_sys.c
+++ b/arch/alpha/kernel/osf_sys.c
@@ -521,7 +521,7 @@ SYSCALL_DEFINE4(osf_mount, unsigned long, typenr, const char __user *, path,
                break;
        default:
                retval = -EINVAL;
-               printk("osf_mount(%ld, %x)\n", typenr, flag);
+               printk_ratelimited("osf_mount(%ld, %x)\n", typenr, flag);
        }

        return retval;
--
2.33.1
Thanks for the patch! This was included in my pull request today and
is now upstream in Linus' tree.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help