Thread (2 messages) 2 messages, 2 authors, 2021-11-24

Re: [PATCH] ACPI: processor idle: fix swap.cocci warning

From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: 2021-11-24 16:48:45
Also in: lkml

On Tue, Nov 9, 2021 at 8:51 AM Guo Zhengkui [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Fix following coccicheck warning:
./drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c:914:40-41:
WARNING opportunity for swap().

swap() was used instead of the tmp variable to swap values.

Signed-off-by: Guo Zhengkui <redacted>
---
 drivers/acpi/processor_idle.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index 76ef1bcc8848..4b906bb527e8 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -20,6 +20,7 @@
 #include <linux/tick.h>
 #include <linux/cpuidle.h>
 #include <linux/cpu.h>
+#include <linux/minmax.h>
 #include <acpi/processor.h>

 /*
@@ -400,13 +401,10 @@ static int acpi_cst_latency_cmp(const void *a, const void *b)
 static void acpi_cst_latency_swap(void *a, void *b, int n)
 {
        struct acpi_processor_cx *x = a, *y = b;
-       u32 tmp;

        if (!(x->valid && y->valid))
                return;
-       tmp = x->latency;
-       x->latency = y->latency;
-       y->latency = tmp;
+       swap(x->latency, y->latency);
 }

 static int acpi_processor_power_verify(struct acpi_processor *pr)
--
Applied as 5.17 material with edited subject and changelog, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help