Thread (2 messages) 2 messages, 2 authors, 2021-10-27

Re: [PATCH] ACPI: APEI: mark apei_hest_parse

From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: 2021-10-27 18:37:34
Also in: lkml

On Wed, Oct 27, 2021 at 8:54 AM Christoph Hellwig [off-list ref] wrote:
quoted hunk ↗ jump to hunk
apei_hest_parse is only used in hest.c, so mark it static.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/acpi/apei/hest.c | 5 +++--
 include/acpi/apei.h      | 3 ---
 2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c
index 277f00b288d14..0edc1ed476737 100644
--- a/drivers/acpi/apei/hest.c
+++ b/drivers/acpi/apei/hest.c
@@ -86,7 +86,9 @@ static int hest_esrc_len(struct acpi_hest_header *hest_hdr)
        return len;
 };

-int apei_hest_parse(apei_hest_func_t func, void *data)
+typedef int (*apei_hest_func_t)(struct acpi_hest_header *hest_hdr, void *data);
+
+static int apei_hest_parse(apei_hest_func_t func, void *data)
 {
        struct acpi_hest_header *hest_hdr;
        int i, rc, len;
@@ -121,7 +123,6 @@ int apei_hest_parse(apei_hest_func_t func, void *data)

        return 0;
 }
-EXPORT_SYMBOL_GPL(apei_hest_parse);

 /*
  * Check if firmware advertises firmware first mode. We need FF bit to be set
diff --git a/include/acpi/apei.h b/include/acpi/apei.h
index 680f80960c3dc..ece0a8af2bae7 100644
--- a/include/acpi/apei.h
+++ b/include/acpi/apei.h
@@ -37,9 +37,6 @@ void __init acpi_hest_init(void);
 static inline void acpi_hest_init(void) { return; }
 #endif

-typedef int (*apei_hest_func_t)(struct acpi_hest_header *hest_hdr, void *data);
-int apei_hest_parse(apei_hest_func_t func, void *data);
-
 int erst_write(const struct cper_record_header *record);
 ssize_t erst_get_record_count(void);
 int erst_get_record_id_begin(int *pos);
--
Applied as 5.16 material, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help