On Wed, Oct 13, 2021 at 08:33:14PM +0200, Rafael J. Wysocki wrote:

On Wed, Oct 13, 2021 at 8:24 PM Andy Shevchenko
[off-list ref] wrote:

quoted

On Wed, Oct 13, 2021 at 07:47:37PM +0200, Rafael J. Wysocki wrote:

quoted

On Thu, Oct 7, 2021 at 7:18 PM Andy Shevchenko
[off-list ref] wrote:

quoted

We have couple of users of this helper, make it available for them.

"a couple"?

Yep.

quoted

quoted

 EXPORT_SYMBOL(device_match_acpi_dev);

+int device_match_acpi_handle(struct device *dev, const void *handle)

Hmmm.  Should the second arg be of type acpi_handle?

acpi_handle is not defined as struct and it means the header, where the
prototype is declared, will require acpi.h to be included. Besides that the
whole set of device_match_*() is done by the same prototype, so it can be used
in bus_find_device() calls.

Ah, OK, it's for bus_find_device().

quoted

quoted

And doesn't this function belong to the ACPI core?  It is related to
acpi_bus_get_device() and such which are located there.

Same as above. I don't think so.

I see, but any chance to improve the changelog?

I will drop this from my testing tree and wait for a new version with a
better changelog.

thanks,

greg k-h