Thread (5 messages) 5 messages, 3 authors, 2021-09-14

Re: [PATCH] ACPI: resources: add legacy irq override exception by DMI info

From: Hui Wang <hidden>
Date: 2021-09-13 13:14:30

Hi Rafael,

Could you please take a look at this patch and give some comment when 
you have time, the patch will not introduce the regression like the 
previous one.

Hi Manuel,

Thanks for your comment. Let's work together to make the keyboard work 
under Linux kernel.

Regards,

Hui.

On 9/5/21 12:04 AM, Manuel Krause wrote:
Hi Hui Wang and all others,

thank you for notifying me and for giving it a new run for the kernel! 
;-)

On 04/09/2021 03:43, Hui Wang wrote:
quoted
After the commit 0ec4e55e9f57 ("ACPI: resources: Add checks for ACPI
IRQ override") is reverted, the keyboard of those Medion laptops can't
work again.

To fix the keyboard issue, here adding an override check by DMI info,
this will not affect other machines and this design refers to
the prt_quirks[] in the drivers/acpi/pci_irq.c.

If we meet similar issues on other platforms, we could expand the
table of skip_override_table[] or medion_laptop[].
^
| IMO this is the major positive aspect of this patch, that it enables 
additions, allowing the kernel to work-around other buggy BIOSs / 
hardware properly in future.

Maybe https://bugzilla.kernel.org/show_bug.cgi?id=213353 "IRQs for 
onboard UARTs are not level-triggered with IRQNoFlags even if the 
parent section has the defaults in PRS" is another candidate to add to 
the table (but I haven't digged deeply enough into it to be sure).

Many thanks to all helpful people involved,
best regards,

Manuel
quoted
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=213031
BugLink: http://bugs.launchpad.net/bugs/1909814
Reported-by: Manuel Krause <redacted>
Tested-by: Manuel Krause <redacted>
Signed-off-by: Hui Wang <redacted>
---
  drivers/acpi/resource.c | 52 ++++++++++++++++++++++++++++++++++++++++-
  1 file changed, 51 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index ee78a210c606..434c8964f182 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
[...]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help