On Thu, Aug 26, 2021 at 8:24 PM Jon Derrick [off-list ref] wrote:

On 8/25/21 9:26 AM, Rafael J. Wysocki wrote:

quoted

On Wed, Aug 25, 2021 at 5:00 PM Bjorn Helgaas [off-list ref] wrote:

quoted

On Wed, Aug 25, 2021 at 11:02:47AM +0000, Wang, Wendy wrote:

quoted

Hi Rafael,

Tested this PATCH v2 against intel next v5.12 kernel on ADL-S NVME and SATA storages:

cat /sys/devices/pci0000\:00/0000\:00\:0e.0/firmware_node/path
\_SB_.PC00.VMD0

10000:e0:17.0 SATA controller: Intel Corporation Device 7ae2 (rev 11)
10000:e0:1d.0 System peripheral: Intel Corporation Device 09ab
10000:e0:1d.4 PCI bridge: Intel Corporation Device 7ab4 (rev 11)
10000:e1:00.0 Non-Volatile memory controller: Samsung Electronics Co Ltd NVMe SSD Controller PM9A1/PM9A3/980PRO

[ 6193.658074] ahci 10000:e0:17.0: PCI PM: Suspend power state: D3hot
[ 6193.658156] nvme 10000:e1:00.0: PCI PM: Suspend power state: D3hot
[ 6193.710883] pcieport 10000:e0:1d.4: PCI PM: Suspend power state: D3cold

This doesn't happen without using the ACPI companion object (the
deepest power state you can get then is D3hot) AFAICS.

quoted

quoted

[ 6193.730318] vmd 0000:00:0e.0: PCI PM: Suspend power state: D3hot

cat /sys/kernel/debug/pmc_core/substate_residencies
Substate   Residency
S0i2.0     0
S0i2.1     13862128

Thanks!

I guess (given Rafael's response) that this is a positive test result,
i.e., you see the desired behavior with this patch?

So yes.

LGTM then

Acked-by: Jon Derrick <redacted>

Thank you!

It doesn't look like there are any concerns regarding this patch, so
I'll queue it up for merging next week.