Re: [PATCH] apci: sysfs: Fixed void function style code issues

On Mon, Jun 14, 2021 at 05:30:25PM +0200, Rafael J. Wysocki wrote:

On Sat, Jun 12, 2021 at 10:10 PM Clayton Casciato
[off-list ref] wrote:

quoted

Fixed coding style issues.

Signed-off-by: Clayton Casciato <redacted>
---
 drivers/acpi/sysfs.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/acpi/sysfs.c b/drivers/acpi/sysfs.c
index d25927195d6d..d6626aba4a6a 100644
--- a/drivers/acpi/sysfs.c
+++ b/drivers/acpi/sysfs.c

@@ -582,8 +582,6 @@ static void delete_gpe_attr_array(void)
                kfree(counter_attrs);
        }
        kfree(all_attrs);
-
-       return;
 }

 static void gpe_count(u32 gpe_number)

@@ -598,8 +596,6 @@ static void gpe_count(u32 gpe_number)
        else
                all_counters[num_gpes + ACPI_NUM_FIXED_EVENTS +
                             COUNT_ERROR].count++;
-
-       return;
 }

 static void fixed_event_count(u32 event_number)

@@ -612,8 +608,6 @@ static void fixed_event_count(u32 event_number)
        else
                all_counters[num_gpes + ACPI_NUM_FIXED_EVENTS +
                             COUNT_ERROR].count++;
-
-       return;
 }

 static void acpi_global_event_handler(u32 event_type, acpi_handle device,

@@ -914,8 +908,6 @@ static void __exit interrupt_stats_exit(void)
        sysfs_remove_group(acpi_kobj, &interrupt_stats_attr_group);

        delete_gpe_attr_array();
-
-       return;
 }

 static ssize_t
--

Applied as 5.14 material with edited subject and changelog.

Thanks!

I'm not sure how to find the edits.
Did you note them for transparency or would you recommend I do something
different in the future?

These are my first patches and any feedback you'd be willing to provide
would be appreciated.

Thank you, Rafael!