Thread (2 messages) 2 messages, 2 authors, 2021-06-30

Re: [PATCH] ACPI / amba: Fix resource name in /proc/iomem

From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: 2021-06-30 18:02:24
Also in: lkml

On Tue, Jun 29, 2021 at 1:28 PM Liguang Zhang
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
In function amba_handler_attach(), dev->res.name is initialized by
amba_device_alloc. But when address_found is false, dev->res.name is
assigned to null value, which leads to wrong resource name display in
/proc/iomem, "<BAD>" is seen for those resources.

Signed-off-by: Liguang Zhang <redacted>
---
 drivers/acpi/acpi_amba.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/acpi/acpi_amba.c b/drivers/acpi/acpi_amba.c
index 49b781a9cd97..ab8a4e0191b1 100644
--- a/drivers/acpi/acpi_amba.c
+++ b/drivers/acpi/acpi_amba.c
@@ -76,6 +76,7 @@ static int amba_handler_attach(struct acpi_device *adev,
                case IORESOURCE_MEM:
                        if (!address_found) {
                                dev->res = *rentry->res;
+                               dev->res.name = dev_name(&dev->dev);
                                address_found = true;
                        }
                        break;
--
Applied as 5.14-rc1 material, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help