On Wed, Jun 23, 2021 at 09:28:55AM -0700, Nathan Chancellor wrote:

On 6/22/2021 10:51 PM, Kees Cook wrote:

quoted

On Tue, Jun 22, 2021 at 06:38:02PM -0700, Nathan Chancellor wrote:

quoted

sysfs_emit is preferred to snprintf for emitting values after
commit 2efc459d06f1 ("sysfs: Add sysfs_emit and sysfs_emit_at to format
sysfs output").

Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Perhaps just squash this into patch 1? Looks good otherwise!

I thought about it but sysfs_emit is a relatively new API and the previous
change may want to be backported but I do not have a strong opinion so I can
squash it if Rafael or Len feel strongly :)

Fair enough. :) I figured since CFI is even newer than sysfs_emit(), it
didn't make sense to backport. Regardless:

Reviewed-by: Kees Cook <redacted>

-- 
Kees Cook