[PATCH] ACPI: APEI: ERST: Fix missing error code in erst_init()
From: Jiapeng Chong <hidden>
Date: 2021-06-01 11:06:12
Also in:
lkml
Subsystem:
acpi, acpi apei, pstore filesystem, the rest · Maintainers:
"Rafael J. Wysocki", Kees Cook, Linus Torvalds
The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'rc'. Eliminate the follow smatch warning: drivers/acpi/apei/erst.c:1114 erst_init() warn: missing error code 'rc'. Reported-by: Abaci Robot <redacted> Signed-off-by: Jiapeng Chong <redacted> --- drivers/acpi/apei/erst.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c
index 242f3c2..492d499 100644
--- a/drivers/acpi/apei/erst.c
+++ b/drivers/acpi/apei/erst.c@@ -1110,9 +1110,10 @@ static int __init erst_init(void) status = acpi_get_table(ACPI_SIG_ERST, 0, (struct acpi_table_header **)&erst_tab); - if (status == AE_NOT_FOUND) + if (status == AE_NOT_FOUND) { + rc = -EINVAL; goto err; - else if (ACPI_FAILURE(status)) { + } else if (ACPI_FAILURE(status)) { const char *msg = acpi_format_exception(status); pr_err("Failed to get table, %s\n", msg); rc = -EINVAL;
--
1.8.3.1