Re: [PATCH v3 1/2] ACPI: Add _PLD panel positions

Hi Erik,

Do I need to add anything to this patch or is it fine like that?

Thanks,
Fabian

On 14.04.21 15:50, Rafael J. Wysocki wrote:

On Wed, Apr 14, 2021 at 10:30 AM Fabian Wüthrich [off-list ref] wrote:

quoted

The ACPI specification v6.3 defines the panel positions in chapter 6.1.8
"_PLD (Physical Location of Device)"

Signed-off-by: Fabian Wüthrich <redacted>
Reviewed-by: Daniel Scally <djrscally@gmail.com>
Reviewed-by: Andy Shevchenko <redacted>

This is ACPICA material.

Erik, can you pick up this one, please?

quoted

---
 include/acpi/acbuffer.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/include/acpi/acbuffer.h b/include/acpi/acbuffer.h
index 18197c16149f..d42e82a82852 100644
--- a/include/acpi/acbuffer.h
+++ b/include/acpi/acbuffer.h

@@ -207,4 +207,13 @@ struct acpi_pld_info {
 #define ACPI_PLD_GET_HORIZ_OFFSET(dword)        ACPI_GET_BITS (dword, 16, ACPI_16BIT_MASK)
 #define ACPI_PLD_SET_HORIZ_OFFSET(dword,value)  ACPI_SET_BITS (dword, 16, ACPI_16BIT_MASK, value)      /* Offset 128+16=144, Len 16 */

+/* Panel position defined in _PLD section of ACPI Specification 6.3 */
+#define ACPI_PLD_PANEL_TOP                     0
+#define ACPI_PLD_PANEL_BOTTOM                  1
+#define ACPI_PLD_PANEL_LEFT                    2
+#define ACPI_PLD_PANEL_RIGHT                   3
+#define ACPI_PLD_PANEL_FRONT                   4
+#define ACPI_PLD_PANEL_BACK                    5
+#define ACPI_PLD_PANEL_UNKNOWN                 6
+
 #endif                         /* ACBUFFER_H */
--

2.31.1