Thread (9 messages) 9 messages, 6 authors, 2021-01-27

Re: [PATCH] ACPI: Test for ACPI_SUCCESS rather than !ACPI_FAILURE

From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: 2021-01-27 17:45:22
Also in: alsa-devel, amd-gfx, linux-hwmon, linux-spi

On Wed, Jan 27, 2021 at 5:06 PM Bjorn Helgaas [off-list ref] wrote:
On Wed, Jan 27, 2021 at 04:44:02PM +0100, Rafael J. Wysocki wrote:
quoted
On Wed, Jan 27, 2021 at 4:16 PM Bjorn Helgaas [off-list ref] wrote:
quoted
On Tue, Jan 26, 2021 at 02:23:17PM -0600, Bjorn Helgaas wrote:
quoted
From: Bjorn Helgaas <bhelgaas@google.com>

The double negative makes it hard to read "if (!ACPI_FAILURE(status))".
Replace it with "if (ACPI_SUCCESS(status))".

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---

This isn't really an ACPI patch, but I'm sending it to you, Rafael, since
it seems easier to just apply these all at once.  But I'd be happy to split
them up into individual patches if you'd rather.
Thanks, everybody.  Rafael, I'll just merge this via my tree to avoid
burdening you.
It may conflict with some janitorial stuff I'm doing, though, so
unless you've already applied it, I'd prefer to take it via the ACPI
tree.
No problem, it's all yours!
Applied as 5.12 material with the ACKs, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help