Thread (2 messages) 2 messages, 2 authors, 2021-01-22

Re: [PATCH -next] pnp: pnpbios: Use DEFINE_SPINLOCK() for spinlock

From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: 2021-01-22 15:25:34
Also in: lkml

On Mon, Dec 28, 2020 at 2:50 PM Zheng Yongjun [off-list ref] wrote:
quoted hunk ↗ jump to hunk
spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().

Signed-off-by: Zheng Yongjun <redacted>
---
 drivers/pnp/pnpbios/bioscalls.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pnp/pnpbios/bioscalls.c b/drivers/pnp/pnpbios/bioscalls.c
index ba5cfc3dbe11..ddc6f2163c8e 100644
--- a/drivers/pnp/pnpbios/bioscalls.c
+++ b/drivers/pnp/pnpbios/bioscalls.c
@@ -72,7 +72,7 @@ __visible u32 pnp_bios_fault_esp;
 __visible u32 pnp_bios_fault_eip;
 __visible u32 pnp_bios_is_utter_crap = 0;

-static spinlock_t pnp_bios_lock;
+static DEFINE_SPINLOCK(pnp_bios_lock);

 /*
  * Support Functions
@@ -473,7 +473,6 @@ void pnpbios_calls_init(union pnp_bios_install_struct *header)
 {
        int i;

-       spin_lock_init(&pnp_bios_lock);
        pnp_bios_callpoint.offset = header->fields.pm16offset;
        pnp_bios_callpoint.segment = PNP_CS16;

--
Applied as 5.12 material, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help