-----Original Message-----
From: Nick Desaulniers <ndesaulniers@google.com>
Sent: Thursday, January 21, 2021 11:08 AM
To: Rafael J. Wysocki <rafael@kernel.org>; Kaneda, Erik
[off-list ref]
Cc: Jon Hunter <jonathanh@nvidia.com>; Moore, Robert
[off-list ref]; Wysocki, Rafael J [off-list ref];
Gustavo A . R . Silva [off-list ref]; clang-built-linux <clang-built-
linux@googlegroups.com>; Len Brown [off-list ref]; ACPI Devel
Maling List [off-list ref]; open list:ACPI COMPONENT
ARCHITECTURE (ACPICA) [off-list ref]; Linux Kernel Mailing List
[off-list ref]; linux-tegra [off-list ref]
Subject: Re: [PATCH] ACPICA: fix -Wfallthrough

On Thu, Jan 21, 2021 at 11:03 AM Rafael J. Wysocki [off-list ref]
wrote:

quoted

On Thu, Jan 21, 2021 at 11:08 AM Jon Hunter [off-list ref]

wrote:

quoted

quoted

On 11/11/2020 02:11, Nick Desaulniers wrote:

quoted

The "fallthrough" pseudo-keyword was added as a portable way to

denote

quoted

quoted

quoted

intentional fallthrough. This code seemed to be using a mix of
fallthrough comments that GCC recognizes, and some kind of lint

marker.

quoted

quoted

quoted

I'm guessing that linter hasn't been run in a while from the mixed use
of the marker vs comments.

Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>

I know this is not the exact version that was merged, I can't find it on
the list, but looks like the version that was merged [0],

It would be this patch:

https://patchwork.kernel.org/project/linux-

acpi/patch/20210115184826.2250-4-erik.kaneda@intel.com/

quoted

Nick, Erik?

oh, shit, looks like a line was dropped.  Here's what I sent upstream:
https://github.com/acpica/acpica/pull/650/files#diff-
cccd96e900e01f7224c81508cbddfb1af6fcfbff959d6bfb55123e1b9cad4e38R154
3
Note in the patch Rafael links to that line is missing and there's
instead an #ifdef that's empty.  Was this line accidentally dropped?

Looks like this line was dropped by ACPICA's Linux-ize scripts. I'll re-add it and send again.

Rafael, do you want me to re-send the series or do you want me to resend the specific commit? I don't mind either way.

Thanks,
Erik

quoted

quoted

is causing build errors with older toolchains (GCC v6) ...

/dvs/git/dirty/git-master_l4t-

upstream/kernel/drivers/acpi/acpica/dscontrol.c: In function
‘acpi_ds_exec_begin_control_op’:

quoted

quoted

/dvs/git/dirty/git-master_l4t-

upstream/kernel/drivers/acpi/acpica/dscontrol.c:65:3: error:
‘ACPI_FALLTHROUGH’ undeclared (first use in this function)

quoted

quoted

   ACPI_FALLTHROUGH;
   ^~~~~~~~~~~~~~~~
/dvs/git/dirty/git-master_l4t-

upstream/kernel/drivers/acpi/acpica/dscontrol.c:65:3: note: each
undeclared identifier is reported only once for each function it appears in

quoted

quoted

/dvs/git/dirty/git-master_l4t-

upstream/kernel/scripts/Makefile.build:287: recipe for target
'drivers/acpi/acpica/dscontrol.o' failed

quoted

quoted

Cheers
Jon

[0] https://github.com/acpica/acpica/commit/4b9135f5

--
nvpublic

--
Thanks,
~Nick Desaulniers