On Thu, 2017-08-31 at 12:56 +0200, Borislav Petkov wrote:

On Wed, Aug 23, 2017 at 04:54:45PM -0600, Toshi Kani wrote:

 :

quoted

---
 drivers/edac/ghes_edac.c |   29 ++++++++++++++++++++++++-----
 1 file changed, 24 insertions(+), 5 deletions(-)

diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c
index 8d904df..0030a09 100644
--- a/drivers/edac/ghes_edac.c
+++ b/drivers/edac/ghes_edac.c

@@ -38,6 +38,10 @@ static struct ghes_edac_pvt *ghes_pvt;

  */
 static DEFINE_SPINLOCK(ghes_lock);
 
+/* Set 1 to skip the platform check */
+static bool __read_mostly ghes_edac_force_load;

It is static - "force_load" as a bool name is enough.

Will do.

quoted

+module_param_named(force_load, ghes_edac_force_load, bool, 0);

ERROR: Use 4 digit octal (0777) not decimal permissions
#53: FILE: drivers/edac/ghes_edac.c:43:
+module_param_named(force_load, ghes_edac_force_load, bool, 0);

This last param is @perm: visibility in sysfs. Why not visible in
sysfs?

I followed in the footsteps of 'ghes_disable', which is also a kernel
boot option and uses 0.

quoted

+
 /* Memory Device - Type 17 of SMBIOS spec */
 struct memdev_dmi_entry {
 	u8 type;

@@ -415,6 +419,15 @@ void ghes_edac_report_mem_error(struct ghes

*ghes, int sev,
 	spin_unlock_irqrestore(&ghes_lock, flags);
 }
 
+/*
+ * Known systems that are safe to enable this module.
+ * "ghes_edac.force_load=1" skips this check if necessary.

Put this second sentence over the parameter definition.

Will do.

Thanks,
-Toshi