Re: [PATCH v3 3/4] device property: Move FW type specific functionality to FW specific files
From: Sakari Ailus <sakari.ailus@linux.intel.com>
Date: 2017-03-21 08:27:06
Also in:
linux-devicetree
From: Sakari Ailus <sakari.ailus@linux.intel.com>
Date: 2017-03-21 08:27:06
Also in:
linux-devicetree
Hi Rob, Rob Herring wrote:
On Thu, Mar 16, 2017 at 8:34 AM, Sakari Ailus [off-list ref] wrote:quoted
The device and fwnode property API supports Devicetree, ACPI and pset properties. The implementation of this functionality for each firmware type was embedded in the fwnode property core. Move it out to firmware type specific locations, making it easier to maintain. Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- drivers/acpi/property.c | 87 +++++++++++++++ drivers/acpi/scan.c | 1 + drivers/base/property.c | 280 +++++++++++++++++++----------------------------- drivers/of/base.c | 99 +++++++++++++++++This is the opposite direction everything else has been moving. For example, I2C parsing is in drivers/i2c. But I guess this is a bit different. In any case, please move this to drivers/of/property.c (and perhaps move all of of_property_* there too).
Ok. There appear to be quite a few functions dealing with properties in drivers/of/base.c either directly reading their values or otherwise accessing them. Let me see if I can find a roughly coherent set of functions to move to property.c. I'll move the existing functions there first, creating a new patch before this one. -- Kind regards, Sakari Ailus sakari.ailus@linux.intel.com