Re: [PATCH] watchdog: wdat_wdt: Ping the watchdog on resume
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: 2016-10-20 15:05:24
Also in:
linux-watchdog
On Thu, Oct 20, 2016 at 5:03 PM, Mika Westerberg [off-list ref] wrote:
It turns out we need to ping the watchdog hardware on resume when we re-program it. Otherwise this results inadvertent reset to trigger right after the resume is completed. Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Is there a Fixes: tag missing here?
quoted hunk ↗ jump to hunk
--- drivers/watchdog/wdat_wdt.c | 4 ++++ 1 file changed, 4 insertions(+)diff --git a/drivers/watchdog/wdat_wdt.c b/drivers/watchdog/wdat_wdt.c index e473e3b23720..6d1fbda0f461 100644 --- a/drivers/watchdog/wdat_wdt.c +++ b/drivers/watchdog/wdat_wdt.c@@ -499,6 +499,10 @@ static int wdat_wdt_resume_noirq(struct device *dev) ret = wdat_wdt_enable_reboot(wdat); if (ret) return ret; + + ret = wdat_wdt_ping(&wdat->wdd); + if (ret) + return ret; } return wdat_wdt_start(&wdat->wdd); --
Thanks, Rafael