Thread (14 messages) 14 messages, 4 authors, 2016-06-21

Re: [RESEND PATCH v3 1/2] device property: Add function to search for named child of device

From: Mika Westerberg <mika.westerberg@linux.intel.com>
Date: 2016-06-21 12:09:41
Also in: alsa-devel, linux-devicetree, lkml

On Tue, Jun 21, 2016 at 01:42:16PM +0200, Rafael J. Wysocki wrote:
quoted
quoted
+static inline bool acpi_data_node_match(struct fwnode_handle *fwnode,
+					const char *name)
+{
+	return is_acpi_data_node(fwnode) ?
+		(!strcasecmp(to_acpi_data_node(fwnode)->name, name)) : false;
+}
Looks fine to me.

One question - is it expected that matching ACPI data nodes is always
case insensitive?
That would not be a correct expectation in theory, although I don't think it
really matters in practice.
OK.

Maybe it is good idea to document that in acpi_data_node_match(). A
comment explaining why we use strcasecmp() for now.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help