Thread (15 messages) 15 messages, 3 authors, 2015-11-02

Re: ACPI: Can I use I2cSerialBus with a PCI I2C controller?

From: Mika Westerberg <mika.westerberg@linux.intel.com>
Date: 2015-10-23 09:43:48

On Fri, Oct 23, 2015 at 11:20:54AM +0300, Mika Westerberg wrote:
On Thu, Oct 22, 2015 at 12:17:58PM -0500, Ben Gardner wrote:
quoted
quoted
The next issue is that the I2C-core isn't matching the device to the
"at24" driver, which has the alias "24c02".
Here is what I found.
i2c-core is creating the device with the ACPI name "24C02:00".
The at24 driver uses "24c02" as the alias.
i2c-code is matching devices to drivers using strcmp().

Result: no match. ("24c02" != "24C02:00").

If I modify acpi_i2c_add_device() to cut off the name at the ':' and
covert to lowercase when populating info.type, it matches and works.
I must be missing something here, because this would have never worked as-is.
I'll ask on the I2C mailing list.
You should either use proper _HID/_CID for the device or put "PRP0001"
to the _HID and let the match happen with DT .compatible strings. I've
attached a hack that I use locally.
Alternatively you can use patch by Andy here:

https://patchwork.ozlabs.org/patch/524923
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help