Thread (89 messages) 89 messages, 8 authors, 2013-01-11

Re: [PATCH 5/6] ACPI: Replace struct acpi_bus_ops with enum type

From: Yinghai Lu <yinghai@kernel.org>
Date: 2012-12-10 05:34:45
Also in: linux-pci, lkml

On Sun, Dec 9, 2012 at 3:03 PM, Rafael J. Wysocki [off-list ref] wrote:
From: Rafael J. Wysocki <redacted>

Notice that one member of struct acpi_bus_ops, acpi_op_add, is not
used anywhere any more and the relationship between its remaining
members, acpi_op_match and acpi_op_start, is such that it doesn't
make sense to set the latter without setting the former at the same
time.  Therefore, replace struct acpi_bus_ops with new a enum type,
enum acpi_bus_add_type, with three values, ACPI_BUS_ADD_BASIC,
ACPI_BUS_ADD_MATCH, ACPI_BUS_ADD_START, corresponding to
both acpi_op_match and acpi_op_start unset, acpi_op_match set and
acpi_op_start unset, and both acpi_op_match and acpi_op_start set,
respectively.
Can we expand the BUS_ADD_* concept to other devices instead of just
acpi_device?

aka we should let struct device has this add_type field.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help