Thread (8 messages) 8 messages, 2 authors, 2012-11-20

Re: [PATCH v6 1/5] ACPI: Add acpi_handle_<level>() interfaces

From: Toshi Kani <hidden>
Date: 2012-11-20 21:20:31
Also in: lkml

On Tue, 2012-11-20 at 13:10 -0800, Joe Perches wrote:
On Tue, 2012-11-20 at 13:44 -0700, Toshi Kani wrote:
quoted
This interface acquires the global namespace
mutex and may not be called from interrupt context.
[]
quoted
diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
[]
quoted
+/**
+ * acpi_handle_printk: Print message with ACPI prefix and object path
+ *
+ * This function is called through acpi_handle_<level> macros and prints
+ * a message with ACPI prefix and object path.  This function acquires
+ * the global namespace mutex and may not be called from interrupt context.
+ */
+void
+acpi_handle_printk(const char *level, acpi_handle handle, const char *fmt, ...)
+{
[]
quoted
+	ret = acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer);
+	if (ret == AE_OK)
+		path = buffer.pointer;
+	else
+		path = "<n/a>";
Perhaps:
	if (in_interrupt() ||
	    acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer) != AE_OK)
		path = "<n/a>";
	else
		path = buffer.pointer;

so that any interrupt context still works, just
not printing the correct acpi_get_name;
Hi Joe,

Good idea.  I will update the patch as you suggested.

Thanks,
-Toshi


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help