Re: [PATCH] ACPI / resources: Use AE_CTRL_TERMINATE to terminate resources walks
From: Mika Westerberg <mika.westerberg@linux.intel.com>
Date: 2012-11-16 14:24:46
Also in:
lkml
On Fri, Nov 16, 2012 at 02:49:10PM +0100, Rafael J. Wysocki wrote:
From: Rafael J. Wysocki <redacted> Currently acpi_dev_process_resource() returns AE_ABORT_METHOD to terminate the acpi_walk_resources() it is called from if the .preproc() routine provided by the caller of acpi_dev_get_resources() initiating the resources walk returns an error code. It is better to use AE_CTRL_TERMINATE for this purpose, however, so do that. Signed-off-by: Rafael J. Wysocki <redacted>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
quoted hunk ↗ jump to hunk
--- drivers/acpi/resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/drivers/acpi/resource.c ===================================================================--- linux.orig/drivers/acpi/resource.c +++ linux/drivers/acpi/resource.c@@ -446,7 +446,7 @@ static acpi_status acpi_dev_process_reso ret = c->preproc(ares, c->preproc_data); if (ret < 0) { c->error = ret; - return AE_ABORT_METHOD; + return AE_CTRL_TERMINATE; } else if (ret > 0) { return AE_OK; }