Thread (34 messages) 34 messages, 2 authors, 2012-08-27

RE: [PATCHv2 06/14] Thermal: Add a policy sysfs attribute

From: "Zhang, Rui" <rui.zhang@intel.com>
Date: 2012-08-27 09:35:06

quoted hunk ↗ jump to hunk
-----Original Message-----
From: R, Durgadoss
Sent: Monday, August 27, 2012 7:28 AM
To: lenb@kernel.org; Zhang, Rui
Cc: linux-acpi@vger.kernel.org; eduardo.valentin@ti.com; R, Durgadoss
Subject: [PATCHv2 06/14] Thermal: Add a policy sysfs attribute
Importance: High

This patch adds a policy sysfs attribute to a thermal zone.
This attribute will give us the throttling policy used for the zone.
This is a RO attribute.

Signed-off-by: Durgadoss R <redacted>
---
 drivers/thermal/thermal_sys.c |   32 ++++++++++++++++++++++++++++++--
 1 file changed, 30 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/thermal_sys.c
b/drivers/thermal/thermal_sys.c index 6adda39..8aa4200a6 100644
--- a/drivers/thermal/thermal_sys.c
+++ b/drivers/thermal/thermal_sys.c
@@ -378,10 +378,32 @@ passive_show(struct device *dev, struct
device_attribute *attr,
 	return sprintf(buf, "%d\n", tz->forced_passive);  }

+static ssize_t
+policy_show(struct device *dev, struct device_attribute *devattr, char
+*buf) {
+	struct thermal_zone_device *tz = to_thermal_zone(dev);
+	struct thermal_zone_params *tzp = tz->tzp;
+
+	if (!tzp)
+		return sprintf(buf, "step_wise(default)\n");
+
+	switch (tzp->throttle_policy) {
+	case THERMAL_FAIR_SHARE:
+		return sprintf(buf, "fair_share\n");
+	case THERMAL_STEP_WISE:
+		return sprintf(buf, "step_wise\n");
+	case THERMAL_USER_SPACE:
+		return sprintf(buf, "user_space\n");
+	default:
+		return sprintf(buf, "unknown\n");
+	}
+}
+
 static DEVICE_ATTR(type, 0444, type_show, NULL);  static
DEVICE_ATTR(temp, 0444, temp_show, NULL);  static DEVICE_ATTR(mode,
0644, mode_show, mode_store);  static DEVICE_ATTR(passive, S_IRUGO |
S_IWUSR, passive_show, passive_store);
+static DEVICE_ATTR(throttle_policy, S_IRUGO, policy_show, NULL);

 /* sys I/F for cooling device */
 #define to_cooling_device(_dev)	\
@@ -1349,10 +1371,16 @@ static int retrieve_zone_params(struct
thermal_zone_device *tz)

 	/* It is not an error to not have any platform data */
 	ret = get_platform_thermal_params(tz);
-	if (ret)
+	if (ret) {
 		tz->tzp = NULL;
+		return 0;
+	}

-	return 0;
+	ret = device_create_file(&tz->device, &dev_attr_throttle_policy);
+	if (ret)
+		dev_err(&tz->device, "creating policy attr failed:%d\n",
ret);
+
+	return ret;
 }

 /**
We should remove this attribute in thermal_zone_device_unregister();

Thanks.
rui
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help