On Thu, 2012-07-19 at 05:35 +0000, Moore, Robert wrote:

quoted

quoted

I wouldn't have a problem renaming a few of those to
something like:

#define ACPI_INFO(plist)	acpi_old_info plist
#define ACPI_WARNING(plist)	acpi_old_warning plist
#define ACPI_ERROR(plist)	acpi_old_error plist

The acpi folk might though.

Hi Joe,

ACPI CA is being developed by Intel as OS-neutral code, and is used by
multiple OSes including Linux.  So, I am not sure how easy to make such
changes.  I am copying to Lin Ming.

Please don't even consider doing something like this. As we continue to
develop and maintain the ACPICA code, these kinds of OS-specific divergences
from the base ACPICA code cause us all kinds of grief, including the accidental
creation of new bugs as it becomes more and more difficult to integrate the base
ACPICA code back into Linux.

Hi Bob,

Thanks for the clarification!  I agree with you.

In fact, we have a major project this year (and probably far into next year) to
continue to minimize (i.e., fix) this type of Linux/ACPICA divergence -- of which
many have crept in over the years that ACPICA has been present in the Linux kernel.

Cool!  I think that's very good improvement.

Thanks again,
-Toshi

Bob

quoted

-----Original Message-----
From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-
owner@vger.kernel.org] On Behalf Of Toshi Kani
Sent: Wednesday, July 18, 2012 3:08 PM
To: Joe Perches; Lin, Ming M
Cc: lenb@kernel.org; linux-acpi@vger.kernel.org; linux-
kernel@vger.kernel.org; bhelgaas@google.com;
isimatu.yasuaki@jp.fujitsu.com; liuj97@gmail.com;
srivatsa.bhat@linux.vnet.ibm.com; prarit@redhat.com; imammedo@redhat.com;
vijaymohan.pandarathil@hp.com
Subject: Re: [PATCH 1/4] ACPI: Add acpi_pr_<level>() interfaces

On Wed, 2012-07-18 at 14:54 -0700, Joe Perches wrote:

quoted

On Wed, 2012-07-18 at 15:41 -0600, Toshi Kani wrote:

quoted

On Wed, 2012-07-18 at 14:21 -0700, Joe Perches wrote:

quoted

On Wed, 2012-07-18 at 14:40 -0600, Toshi Kani wrote:

quoted

This patch introduces acpi_pr_<level>(), where <level> is a message
level such as err/warn/info, to support improved logging messages
for ACPI, esp. in hotplug operations.  acpi_pr_<level>() appends
"ACPI" prefix and ACPI object path to the messages.  This improves
diagnostics in hotplug operations since it identifies an object

that

quoted

quoted

quoted

quoted

caused an issue in a log file.

[]

quoted

quoted

I'd be tempted to instead make the calls more like
other <subsystem>_<level> uses and rename these to
acpi_<level> and change the existing acpi_info to
another name.

[]

quoted

I agree with you.  Unfortunately, the ACPI CA (ACPI FW interpreter)
already uses them for its internal-use as follows, so I needed to come
up with some other name...  Hence, acpi_pr_<level>.

/*
 * Error reporting. Callers module and line number are inserted by

AE_INFO,

quoted

quoted

 * the plist contains a set of parens to allow variable-length lists.
 * These macros are used for both the debug and non-debug versions of

the code.

quoted

quoted

 */
#define ACPI_INFO(plist)                acpi_info plist
#define ACPI_WARNING(plist)             acpi_warning plist
#define ACPI_EXCEPTION(plist)           acpi_exception plist
#define ACPI_ERROR(plist)               acpi_error plist
#define ACPI_DEBUG_OBJECT(obj,l,i)

acpi_ex_do_debug_object(obj,l,i)

quoted

I wouldn't have a problem renaming a few of those to
something like:

#define ACPI_INFO(plist)	acpi_old_info plist
#define ACPI_WARNING(plist)	acpi_old_warning plist
#define ACPI_ERROR(plist)	acpi_old_error plist

The acpi folk might though.

Hi Joe,

ACPI CA is being developed by Intel as OS-neutral code, and is used by
multiple OSes including Linux.  So, I am not sure how easy to make such
changes.  I am copying to Lin Ming.

quoted

quoted

quoted

Other than that, seems fine to me.

Great!  Can I consider it as Ack? :)

Fix the kfree first.

Please see my other email.  Do you think the check should be added
despite of the warning message?

quoted

I rarely ack stuff as other people generally have to
pick up the changes and I think acks are overrated.

That's fair enough.

Thanks!
-Toshi

quoted

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html