Thread (5 messages) read the whole thread 5 messages, 1 author, 2008-02-23
DORMANTno replies REVIEWED: 2 (2M)

1 review trailer.

[PATCH] ACPI: video - fix permissions on some proc entries

From: Len Brown <lenb@kernel.org>
Date: 2008-02-23 06:19:06
Subsystem: acpi, the rest · Maintainers: "Rafael J. Wysocki", Linus Torvalds

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>

POST and DOS are supposed to be writable but permissions
did not allow it.

Signed-off-by: Dmitry Torokhov <redacted>
Acked-by: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Len Brown <redacted>
---
 drivers/acpi/video.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 2268ab6..831f5f4 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -1276,7 +1276,7 @@ static int acpi_video_bus_add_fs(struct acpi_device *device)
 	entry->owner = THIS_MODULE;
 
 	/* 'POST' [R/W] */
-	entry = create_proc_entry("POST", S_IFREG | S_IRUGO | S_IRUSR,
+	entry = create_proc_entry("POST", S_IFREG | S_IRUGO | S_IWUSR,
 				  device_dir);
 	if (!entry)
 		goto err_remove_post_info;
@@ -1287,7 +1287,7 @@ static int acpi_video_bus_add_fs(struct acpi_device *device)
 	entry->owner = THIS_MODULE;
 
 	/* 'DOS' [R/W] */
-	entry = create_proc_entry("DOS", S_IFREG | S_IRUGO | S_IRUSR,
+	entry = create_proc_entry("DOS", S_IFREG | S_IRUGO | S_IWUSR,
 			      device_dir);
 	if (!entry)
 		goto err_remove_post;
-- 
1.5.4.2.184.gb23b
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help