Thread (75 messages) 75 messages, 16 authors, 2007-08-05

Re: [linux-pm] Re: [PATCH 2/2] Introduce CONFIG_SUSPEND (updated)

From: Rafael J. Wysocki <hidden>
Date: 2007-07-31 09:52:43
Also in: lkml

On Tuesday, 31 July 2007 11:16, Oliver Neukum wrote:
Am Dienstag 31 Juli 2007 schrieb Rafael J. Wysocki:
quoted
Well, the people on linux-pm seem to agree that the .suspend() and .resume()
callbacks are not suitable for runtime power management, so having them
built without SUSPEND or HIBERNATION wouldn't be very useful. ;-)
These are what USB runtime power management uses.
To be precise, I think the rule should be that if some code is needed for
anything else than suspend/hibernation, it should be under plain CONFIG_PM.
Still, if something is only needed for suspend/hibernation, it should go under
CONFIG_PM_SLEEP or CONFIG_SUSPEND/HIBERNATION, depending on what it's needed
for.

Now, AFAICS, for the majority of drivers .suspend() and .resume() are only
needed for suspend/hibernation and really should be used for suspending
only (some other callbacks are needed for hibernation).
How many code paths for power management do you want to introduce?
At least one more, for hibernation.

That also depends on what approach to the runtime power management is widely
accepted.  For now, USB is in the vanguard. :-)

Greetings,
Rafael


-- 
"Premature optimization is the root of all evil." - Donald Knuth
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help