Re: [PATCH,RFC]: acpi,backlight: MSI S270 - driver, second try
From: Pavel Machek <hidden>
Date: 2006-08-17 15:22:06
Also in:
lkml
Hi!
- Remove /proc/acpi/s270 interface, replace it by a platform device /sys/devices/platform/s270pf/. This means: no procfs is touched anymore, all features are now accessible through /sys/. This patch applies to 2.6.17 and requires the ACPI ec_transaction() patch I posted earlier: http://marc.theaimsgroup.com/?l=linux-acpi&m=115517193511970&w=2 Please comment and/or apply!
Looks ok to me...
+static int auto_brightness;
+module_param(auto_brightness, int, 0);
+MODULE_PARM_DESC(auto_brightness, "Enable automatic brightness control (0: disabled; 1: enabled; 2: don't touch)");
+
+/*** Hardware access ***/
+
+static const uint8_t lcd_table[MSI_LCD_LEVEL_MAX] = {
+ 0x00, 0x1f, 0x3e, 0x5d, 0x7c, 0x9b, 0xba, 0xd9, 0xf8
+};Can we get 0xf8 levels and simplify code while we are at it?
+ if ((result = ec_transaction(MSI_EC_COMMAND_LCD_LEVEL, &wdata, 1, &rdata, 1)) < 0) + return result;
Please split this into two lines. result = ...; if (result.....)
+static DEVICE_ATTR(bluetooth, 0444, show_bluetooth, NULL); +static DEVICE_ATTR(wlan, 0444, show_wlan, NULL);
So bluetooth and wlan basically mirror physical switch state? Should we make these switches available through input subsystem one day? -- Thanks for all the (sleeping) penguins.