Re: [PATCH]Panasonic Hotkey Driver
flat view
From: Hiroshi Miura <hidden>
Date: 2004-08-21 10:34:10
At Sat, 21 Aug 2004 01:44:03 -0700, David Bronaugh wrote:
OK, this all makes sense now. It seems like the best way to do screen brightness setting would be to read fields 2 and 3 from SINF into internal fields (pcc_max_bright and pcc_min_bright?) to check user input and make sure it is not outside these bounds.
these are ok? pcc_ac_max_bright pcc_ac_min_bright pcc_dc_max_bright pcc_dc_min_bright
I don't think it is necessary to adjust (or read) fields 5 6 and 7 -- could you confirm on your R3 that these are not necessary (try the things I tried on my R1N)? If you can confirm this, we can simplify the driver to only expose 1 field for the 'brightness' control.
I think it is necessary to adjuct field 5 6 and 7. This sinf is kept through hibernate/power off and on. BIOS show this field when boot or resume and set brightness according as power state. User space utility should set these values as machine power state. when ac/battery power state is changed, user space utility also should set brightness as read from sinf field 4 or 7 according as power state. One idea is driver checks power state and set proper field. This make simplify user/kernel interface. -- Hiroshi Miura --- http://www.da-cha.org/ --- miura-yiisDzvROlQdnm+yROfE0A@public.gmane.org NTTDATA Corp. OpenSource Software Center. --- miurahr-3MafRgGXt7BL9jVzuh4AOg@public.gmane.org NTTDATA Intellilink Corp. OpenSource Engineering Dev. -- miurahr-w0OK63jvRlAuJ+9fw/WgBHgSJqDPrsil@public.gmane.org Key fingerprint = 9117 9407 5684 FBF1 4063 15B4 401D D077 04AB 8617 ------------------------------------------------------- SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33 Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift. http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285