Re: swsusp/s3: Assembly interactions need asmlinkage
From: Pavel Machek <hidden>
Date: 2004-02-25 10:11:19
Also in:
lkml
Hi!
quoted
swsusp/s3 assembly parts, and parts called from assembly are not properly marked asmlinkage; that leads to double fault on resume when someone compiles kernel with regparm. Thanks go to Stefan Seyfried for discovering this. Please apply,Does acpi_enter_sleep_state_s4bios() have the same issue ?
Yes, it does; I missed that. Thanks. Here's the fix. Pavel
--- clean/drivers/acpi/hardware/hwsleep.c 2004-02-05 01:53:59.000000000 +0100
+++ linux/drivers/acpi/hardware/hwsleep.c 2004-02-25 11:08:15.000000000 +0100@@ -359,7 +359,7 @@ * ******************************************************************************/ -acpi_status +acpi_status asmlinkage acpi_enter_sleep_state_s4bios ( void) {
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click