Re: More seq-file fixes for /proc/acpi
From: John Belmonte <hidden>
Date: 2003-02-14 21:18:46
Pavel Machek wrote:
More seq-file fixes. [This is not a dup ;-)] Toshiba maintainer, please fix your stuff yourself. This should fix all /proc write problems in acpi I know... Please apply,
quoted hunk
--- clean/drivers/acpi/toshiba_acpi.c 2003-02-11 17:40:46.000000000 +0100 +++ linux/drivers/acpi/toshiba_acpi.c 2003-02-13 23:17:16.000000000 +0100@@ -519,6 +519,7 @@ if (proc) { proc->proc_fops = &toshiba_lcd_fops; proc->proc_fops->write = proc_write_lcd; +#warning You need to fix up after converting to seq_file; see thermal.c for examples. } proc = create_proc_entry(PROC_VIDEO, S_IFREG | S_IRUGO | S_IWUSR,
I take exception to this. The person who converted my driver to seq_file should be responsible for finishing the job. I disagreed with the conversion to seq_file because it doesn't support an object oriented programming style, as I explained in a posting at the time the conversion took place. -John -- http:// if l . / ------------------------------------------------------- This SF.NET email is sponsored by: FREE SSL Guide from Thawte are you planning your Web Server Security? Click here to get a FREE Thawte SSL guide and find the answers to all your SSL security issues. http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0026en