Re: [PATCH] warning: implicit declaration of function mp_config_ioapic_for_sci
From: Matthew Wilcox <hidden>
Date: 2002-10-09 13:42:32
On Wed, Oct 09, 2002 at 01:14:13AM -0400, Sérgio Monteiro Basto wrote:
First of all thanks for replying to this email and for the information. so I remade the patch, and (I think) now is a good patch, because is not need declared the mp_config_ioapic_for_sci function.
quoted hunk
--- linux-2.4.19orig/drivers/acpi/bus.c Sun Oct 6 21:39:56 2002 +++ linux-2.4.19acpi/drivers/acpi/bus.c Wed Oct 9 01:00:12 2002@@ -1883,10 +1883,14 @@ #ifdef CONFIG_X86 /* Ensure the SCI is set to level-triggered, active-low */ +#ifdef CONFIG_X86_IO_APIC if (acpi_ioapic) mp_config_ioapic_for_sci(acpi_fadt.sci_int); else eisa_set_level_irq(acpi_fadt.sci_int); +#else + eisa_set_level_irq(acpi_fadt.sci_int); +#endif #endif status = acpi_enable_subsystem(ACPI_FULL_INITIALIZATION);
the normal way to do this kind of this is:
quoted hunk
#ifdef CONFIG_X86 /* Ensure the SCI is set to level-triggered, active-low */ +#ifdef CONFIG_X86_IO_APIC if (acpi_ioapic) mp_config_ioapic_for_sci(acpi_fadt.sci_int); else +#endif eisa_set_level_irq(acpi_fadt.sci_int); #endif
(could someone fix the indenting here? it's a mess!) -- Revolutions do not require corporate support. ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf