Re: [Discontig-devel] RE: Cleanup of NUMA support in ACPI

Hi Andy,

On Wed, 14 Aug 2002 10:54:53 -0700
"Grover, Andrew" [off-list ref] wrote:

quoted

From: KOCHI, Takayoshi [mailto:t-kouchi-dPjYVeZdYcz+G+EEi5ephHgSJqDPrsil@public.gmane.org] 
As I promised, I cleaned up NUMA support of ACPI and divided into
architecture-dependent part and architecture-independent part.

In this patch, I introduced a new config parameter 'CONFIG_ACPI_NUMA'.
At this moment, it is independent of CONFIG_NUMA but can be
tristated.  The division is because I'd like to distinguish
ACPI-dependent NUMA initialization stuff and
others (like SGI or phoney_srat/slit).

Nice.

My only comment is that instead of the ifdef CONFIG_ACPI_NUMA chunk in
tables.c, this should just go in a separate file, say, drivers/acpi/numa.c.

My only concern was that as parsing of MADT and SRAT is mostly common,
we have to change common functions from static to extern to
split numa functions to other file.
But I don't see any problem because these function names are
not invasive to others.

There are a bunch of other ACPI config options that should be split out like
this as well, so if you don't want to redo the patch, I'll just take it and
it can get fixed in a sweep with the others, later.

Erich has worked to clean up some portions and sent to LKML.
I'll split ACPI part from the patch and send to you this afternoon.

BTW I was thinking I should only take the arch-neutral changes, and let you
push the rest through David. Does that sound right?

Yes.
It's the dependency that if you won't accept the changes, David won't...

Thanks,
-- 
KOCHI, Takayoshi <t-kouchi-f7IHDacdhdx8UrSeD/g0lQ@public.gmane.org/t-kouchi>



-------------------------------------------------------
This sf.net email is sponsored by: Dice - The leading online job board
for high-tech professionals. Search and apply for tech jobs today!
http://seeker.dice.com/seeker.epl?rel_code=31