Thread (13 messages) 13 messages, 5 authors, 2021-09-21

Re: [kvm-unit-tests PATCH 1/2] Makefile: Fix cscope

From: Andrew Jones <hidden>
Date: 2021-09-21 06:58:21

On Mon, Sep 20, 2021 at 08:04:02PM +0200, Paolo Bonzini wrote:
On 20/09/21 16:10, Andrew Jones wrote:
quoted
Hi Paolo,

You'll get a conflict when you go to merge because I already did it :-)

commit 3d4eb24cb5b4de6c26f79b849fe2818d5315a691 (origin/misc/queue, misc/queue)
Author: Andrew Jones [off-list ref]
Date:   Fri Aug 27 12:25:27 2021 +0200

     Makefile: Don't trust PWD
     PWD comes from the environment and it's possible that it's already
     set to something which isn't the full path of the current working
     directory. Use the make variable $(CURDIR) instead.
     Reviewed-by: Pierre Morel [off-list ref]
     Reviewed-by: Thomas Huth [off-list ref]
     Suggested-by: Thomas Huth [off-list ref]
     Signed-off-by: Andrew Jones [off-list ref]



misc/queue is something I recently invented for stuff like this in order
to help lighten your load a bit.
Ok, are you going to create a merge request?
I did. And I merged it.

https://gitlab.com/kvm-unit-tests/kvm-unit-tests/-/merge_requests/16

Thanks,
drew 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help