Thread (28 messages) 28 messages, 3 authors, 2021-08-09

Re: [PATCH v3 03/14] KVM: s390: pv: leak the ASCE page when destroy fails

From: David Hildenbrand <hidden>
Date: 2021-08-06 07:32:01
Also in: linux-s390, lkml

On 04.08.21 17:40, Claudio Imbrenda wrote:
When a protected VM is created, the topmost level of page tables of its
ASCE is marked by the Ultravisor; any attempt to use that memory for
protected virtualization will result in failure.

Only a successful Destroy Configuration UVC will remove the marking.

When the Destroy Configuration UVC fails, the topmost level of page
tables of the VM does not get its marking cleared; to avoid issues it
must not be used again.

Since the page becomes in practice unusable, we set it aside and leak it.
Instead of leaking, can't we add it to some list and try again later? Or 
do we only expect permanent errors?

Also, we really should bail out loud (pr_warn) to tell the admin that 
something really nasty is going on.

-- 
Thanks,

David / dhildenb
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help