Thread (16 messages) 16 messages, 3 authors, 2021-08-09

Re: [kvm-unit-tests PATCH v1 2/4] s390x: lib: Move stsi_get_fc to library

From: Pierre Morel <hidden>
Date: 2021-08-09 14:23:11
Also in: linux-s390


On 8/9/21 12:16 PM, Janosch Frank wrote:
On 8/9/21 10:48 AM, Pierre Morel wrote:
quoted
It's needed in multiple tests now.

Signed-off-by: Pierre Morel <redacted>
---
  lib/s390x/asm/arch_def.h | 16 ++++++++++++++++
  s390x/stsi.c             | 16 ----------------
  2 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/lib/s390x/asm/arch_def.h b/lib/s390x/asm/arch_def.h
index 15cf7d48..57d7ddac 100644
--- a/lib/s390x/asm/arch_def.h
+++ b/lib/s390x/asm/arch_def.h
@@ -328,6 +328,22 @@ static inline int stsi(void *addr, int fc, int sel1, int sel2)
  	return cc;
  }
  
+static inline unsigned long stsi_get_fc(void *addr)
We don't need an address for fc == 0. You can remove that and fix the
s390x/stsi.c call.
OK, I do that.
Thanks,

Pierre


-- 
Pierre Morel
IBM Lab Boeblingen
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help