Re: [PATCH 12/12] vfio/pci: Introduce vfio_pci_core.ko
From: Christoph Hellwig <hch@lst.de>
Date: 2021-07-28 12:30:01
Also in:
linux-doc, linux-kbuild, linux-pci, linux-s390
From: Christoph Hellwig <hch@lst.de>
Date: 2021-07-28 12:30:01
Also in:
linux-doc, linux-kbuild, linux-pci, linux-s390
On Wed, Jul 28, 2021 at 09:03:26AM -0300, Jason Gunthorpe wrote:
I'm not great with kconfig, but AFAIK: - It controls building a module so it needs to be a tristate - tristates need to be exposed in the menu structure
select can be used on tristates perfectly fine.
- As it builds a module it also has depends on other things
So the dependencies are: - VFIO - duh, yeah, anything vfio related needs to select that. But this is a perfectly fine transitive select - PCI - yeah. But we can expect everything that selects VFIO_PCI_CORE to select PCI. Or a transitive select would be fine again - EVENTFD this is another classic transitive one that should just be selected instead of a user asking why it is not set - MMU: I suspect all of VFIO and thus the menuconfig really should depend on that So not really an issue here. VFIO_PCI_CORE really is underlying infrastructure a user should not care about.