Re: [PATCH v9 07/17] virtio: Don't set FAILED status bit on device index allocation failure

From
Yongji Xie <hidden>
Date
2021-07-13 11:25:48
Also in
linux-fsdevel, linux-iommu, lkml, netdev
Reply to
Dan Carpenter, 2021-07-13
On Tue, Jul 13, 2021 at 7:02 PM Dan Carpenter [off-list ref] wrote:
On Tue, Jul 13, 2021 at 04:46:46PM +0800, Xie Yongji wrote:
quoted
We don't need to set FAILED status bit on device index allocation
failure since the device initialization hasn't been started yet.
The commit message should say what the effect of this change is to the
user.  Is this a bugfix?  Will it have any effect on runtime at all?
Thanks for the reminder. Will update the commit message.
To me, hearing your thoughts on this is valuable even if you have to
guess.  "I noticed this mistake during review and I don't think it will
affect runtime."
Yes, that's what I thought.

Thanks,
Yongji
Thread (45 messages) 45 messages, 7 authors, last reply 2021-12-16
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help