On 7/21/2021 4:05 PM, Jason Gunthorpe wrote:

From: Yishai Hadas <yishaih@nvidia.com>

The only implementation of this in IGD returns a -ERRNO which is
implicitly cast through a size_t and then casted again and returned as a
ssize_t in vfio_pci_rw().

Fix the vfio_pci_regops->rw() return type to be ssize_t so all is
consistent.

Fixes: 28541d41c9e0 ("vfio/pci: Add infrastructure for additional device specific regions")
Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
---
  drivers/vfio/pci/vfio_pci_igd.c     | 10 +++++-----
  drivers/vfio/pci/vfio_pci_private.h |  2 +-
  2 files changed, 6 insertions(+), 6 deletions(-)

v3:
  - Fix commit subject and missing signed-off-by

Looks good,

Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>