Re: [PATCH v2 45/46] KVM: SVM: Drop redundant clearing of vcpu->arch.hflags... | kvm

[PATCH v2 00/46] KVM: x86: vCPU RESET/INIT fixes and consolidation · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 01/46] KVM: x86: Flush the guest's TLB on INIT · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 02/46] KVM: nVMX: Set LDTR to its architecturally defined value on nested VM-Exit · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 03/46] KVM: SVM: Zero out GDTR.base and IDTR.base on INIT · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 04/46] KVM: VMX: Set EDX at INIT with CPUID.0x1, Family-Model-Stepping · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 05/46] KVM: SVM: Require exact CPUID.0x1 match when stuffing EDX at INIT · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 06/46] KVM: SVM: Fall back to KVM's hardcoded value for EDX at RESET/INIT · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 08/46] KVM: SVM: Drop explicit MMU reset at RESET/INIT · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 07/46] KVM: VMX: Remove explicit MMU reset in enter_rmode() · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 09/46] KVM: SVM: Drop a redundant init_vmcb() from svm_create_vcpu() · Sean Christopherson <seanjc@google.com> · 2021-07-13
Re: [PATCH v2 09/46] KVM: SVM: Drop a redundant init_vmcb() from svm_create_vcpu() · Paolo Bonzini <pbonzini@redhat.com> · 2021-07-26
Re: [PATCH v2 09/46] KVM: SVM: Drop a redundant init_vmcb() from svm_create_vcpu() · Sean Christopherson <seanjc@google.com> · 2021-07-26
[PATCH v2 10/46] KVM: VMX: Move init_vmcs() invocation to vmx_vcpu_reset() · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 11/46] KVM: x86: WARN if the APIC map is dirty without an in-kernel local APIC · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 12/46] KVM: x86: Remove defunct BSP "update" in local APIC reset · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 13/46] KVM: x86: Migrate the PIT only if vcpu0 is migrated, not any BSP · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 14/46] KVM: x86: Don't force set BSP bit when local APIC is managed by userspace · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 15/46] KVM: x86: Set BSP bit in reset BSP vCPU's APIC base by default · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 17/46] KVM: x86: Open code necessary bits of kvm_lapic_set_base() at vCPU RESET · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 16/46] KVM: VMX: Stuff vcpu->arch.apic_base directly at vCPU RESET · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 18/46] KVM: x86: Consolidate APIC base RESET initialization code · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 19/46] KVM: x86: Move EDX initialization at vCPU RESET to common code · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 20/46] KVM: SVM: Don't bother writing vmcb->save.rip at vCPU RESET/INIT · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 22/46] KVM: VMX: Remove direct write to vcpu->arch.cr0 during vCPU RESET/INIT · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 21/46] KVM: VMX: Invert handling of CR0.WP for EPT without unrestricted guest · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 23/46] KVM: VMX: Fold ept_update_paging_mode_cr0() back into vmx_set_cr0() · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 25/46] KVM: VMX: Pull GUEST_CR3 from the VMCS iff CR3 load exiting is disabled · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 24/46] KVM: nVMX: Do not clear CR3 load/store exiting bits if L1 wants 'em · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 26/46] KVM: x86/mmu: Skip the permission_fault() check on MMIO if CR0.PG=0 · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 27/46] KVM: VMX: Process CR0.PG side effects after setting CR0 assets · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 28/46] KVM: VMX: Skip emulation required checks during pmode/rmode transitions · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 29/46] KVM: nVMX: Don't evaluate "emulation required" on nested VM-Exit · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 30/46] KVM: SVM: Tweak order of cr0/cr4/efer writes at RESET/INIT · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 31/46] KVM: SVM: Drop redundant writes to vmcb->save.cr4 at RESET/INIT · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 32/46] KVM: SVM: Stuff save->dr6 at during VMSA sync, not at RESET/INIT · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 34/46] KVM: VMX: Refresh list of user return MSRs after setting guest CPUID · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 33/46] KVM: VMX: Skip pointless MSR bitmap update when setting EFER · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 35/46] KVM: VMX: Don't _explicitly_ reconfigure user return MSRs on vCPU INIT · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 36/46] KVM: x86: Move setting of sregs during vCPU RESET/INIT to common x86 · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 38/46] KVM: nVMX: Remove obsolete MSR bitmap refresh at nested transitions · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 41/46] KVM: VMX: Smush x2APIC MSR bitmap adjustments into single function · Sean Christopherson <seanjc@google.com> · 2021-07-13
Re: [PATCH v2 41/46] KVM: VMX: Smush x2APIC MSR bitmap adjustments into single function · Paolo Bonzini <pbonzini@redhat.com> · 2021-07-26
Re: [PATCH v2 41/46] KVM: VMX: Smush x2APIC MSR bitmap adjustments into single function · Sean Christopherson <seanjc@google.com> · 2021-07-26
Re: [PATCH v2 41/46] KVM: VMX: Smush x2APIC MSR bitmap adjustments into single function · Paolo Bonzini <pbonzini@redhat.com> · 2021-07-26
[PATCH v2 40/46] KVM: VMX: Remove unnecessary initialization of msr_bitmap_mode · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 39/46] KVM: VMX: Don't redo x2APIC MSR bitmaps when userspace filter is changed · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 42/46] KVM: VMX: Remove redundant write to set vCPU as active at RESET/INIT · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 44/46] KVM: SVM: Emulate #INIT in response to triple fault shutdown · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 43/46] KVM: VMX: Move RESET-only VMWRITE sequences to init_vmcs() · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 37/46] KVM: VMX: Remove obsolete MSR bitmap refresh at vCPU RESET/INIT · Sean Christopherson <seanjc@google.com> · 2021-07-13
[PATCH v2 45/46] KVM: SVM: Drop redundant clearing of vcpu->arch.hflags at INIT/RESET · Sean Christopherson <seanjc@google.com> · 2021-07-13
Re: [PATCH v2 45/46] KVM: SVM: Drop redundant clearing of vcpu->arch.hflags at INIT/RESET · Reiji Watanabe <hidden> · 2021-07-20
Re: [PATCH v2 45/46] KVM: SVM: Drop redundant clearing of vcpu->arch.hflags at INIT/RESET · Paolo Bonzini <pbonzini@redhat.com> · 2021-07-26
[PATCH v2 46/46] KVM: x86: Preserve guest's CR0.CD/NW on INIT · Sean Christopherson <seanjc@google.com> · 2021-07-13
Re: [PATCH v2 46/46] KVM: x86: Preserve guest's CR0.CD/NW on INIT · Reiji Watanabe <hidden> · 2021-07-20
Re: [PATCH v2 46/46] KVM: x86: Preserve guest's CR0.CD/NW on INIT · Nadav Amit <hidden> · 2021-07-27
Re: [PATCH v2 46/46] KVM: x86: Preserve guest's CR0.CD/NW on INIT · Sean Christopherson <seanjc@google.com> · 2021-07-28
Re: [PATCH v2 00/46] KVM: x86: vCPU RESET/INIT fixes and consolidation · Paolo Bonzini <pbonzini@redhat.com> · 2021-07-26

Re: [PATCH v2 45/46] KVM: SVM: Drop redundant clearing of vcpu->arch.hflags at INIT/RESET

From: Reiji Watanabe <hidden>
Date: 2021-07-20 04:37:25
Also in: lkml

On Tue, Jul 13, 2021 at 9:35 AM Sean Christopherson [off-list ref] wrote:

Drop redundant clears of vcpu->arch.hflags in init_vmcb() now that
init_vmcb() is invoked only through kvm_vcpu_reset(), which always clears
hflags.  And of course, the second clearing in init_vmcb() was always
redundant.

Suggested-by: Reiji Watanabe <redacted>
Signed-off-by: Sean Christopherson <seanjc@google.com>

Reviewed-by: Reiji Watanabe <redacted>

Thank you for removing the redundant code.

Regards,
Reiji

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help