Thread (2 messages) 2 messages, 2 authors, 2021-06-01

Re: [PATCH][next] KVM: x86: Fix fall-through warnings for Clang

From: Paolo Bonzini <pbonzini@redhat.com>
Date: 2021-06-01 08:21:10
Also in: linux-hardening, lkml

On 28/05/21 22:07, Gustavo A. R. Silva wrote:
quoted hunk ↗ jump to hunk
In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple
of warnings by explicitly adding break statements instead of just letting
the code fall through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
JFYI: We had thousands of these sorts of warnings and now we are down
       to just 25 in linux-next. These are some of those last remaining
       warnings.

  arch/x86/kvm/cpuid.c   | 1 +
  arch/x86/kvm/vmx/vmx.c | 1 +
  2 files changed, 2 insertions(+)
diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
index 9a48f138832d..b4da665bb892 100644
--- a/arch/x86/kvm/cpuid.c
+++ b/arch/x86/kvm/cpuid.c
@@ -655,6 +655,7 @@ static int __do_cpuid_func_emulated(struct kvm_cpuid_array *array, u32 func)
  		if (kvm_cpu_cap_has(X86_FEATURE_RDTSCP))
  			entry->ecx = F(RDPID);
  		++array->nent;
+		break;
  	default:
  		break;
  	}
diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index 4bceb5ca3a89..e7d98c3d398e 100644
--- a/arch/x86/kvm/vmx/vmx.c
+++ b/arch/x86/kvm/vmx/vmx.c
@@ -6248,6 +6248,7 @@ void vmx_set_virtual_apic_mode(struct kvm_vcpu *vcpu)
  	switch (kvm_get_apic_mode(vcpu)) {
  	case LAPIC_MODE_INVALID:
  		WARN_ONCE(true, "Invalid local APIC state");
+		break;
  	case LAPIC_MODE_DISABLED:
  		break;
  	case LAPIC_MODE_XAPIC:
Queued, thanks.

Paolo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help