Re: [PATCH 30/43] KVM: SVM: Drop redundant writes to vmcb->save.cr4 at RESET/INIT

[PATCH 00/43] KVM: x86: vCPU RESET/INIT fixes and consolidation · Sean Christopherson <seanjc@google.com> · 2021-04-24
[PATCH 01/43] KVM: nVMX: Set LDTR to its architecturally defined value on nested VM-Exit · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 01/43] KVM: nVMX: Set LDTR to its architecturally defined value on nested VM-Exit · Reiji Watanabe <hidden> · 2021-05-19
[PATCH 02/43] KVM: VMX: Set EDX at INIT with CPUID.0x1, Family-Model-Stepping · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 02/43] KVM: VMX: Set EDX at INIT with CPUID.0x1, Family-Model-Stepping · Reiji Watanabe <hidden> · 2021-05-19
Re: [PATCH 02/43] KVM: VMX: Set EDX at INIT with CPUID.0x1, Family-Model-Stepping · Sean Christopherson <seanjc@google.com> · 2021-05-19
Re: [PATCH 02/43] KVM: VMX: Set EDX at INIT with CPUID.0x1, Family-Model-Stepping · Reiji Watanabe <hidden> · 2021-05-21
Re: [PATCH 02/43] KVM: VMX: Set EDX at INIT with CPUID.0x1, Family-Model-Stepping · Sean Christopherson <seanjc@google.com> · 2021-05-21
Re: [PATCH 02/43] KVM: VMX: Set EDX at INIT with CPUID.0x1, Family-Model-Stepping · Reiji Watanabe <hidden> · 2021-05-24
[PATCH 03/43] KVM: SVM: Require exact CPUID.0x1 match when stuffing EDX at INIT · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 03/43] KVM: SVM: Require exact CPUID.0x1 match when stuffing EDX at INIT · Reiji Watanabe <hidden> · 2021-05-19
[PATCH 04/43] KVM: SVM: Fall back to KVM's hardcoded value for EDX at RESET/INIT · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 04/43] KVM: SVM: Fall back to KVM's hardcoded value for EDX at RESET/INIT · Reiji Watanabe <hidden> · 2021-05-19
[PATCH 05/43] KVM: x86: Split out CR0/CR4 MMU role change detectors to separate helpers · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 05/43] KVM: x86: Split out CR0/CR4 MMU role change detectors to separate helpers · Reiji Watanabe <hidden> · 2021-05-19
[PATCH 06/43] KVM: x86: Properly reset MMU context at vCPU RESET/INIT · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 06/43] KVM: x86: Properly reset MMU context at vCPU RESET/INIT · Reiji Watanabe <hidden> · 2021-05-17
Re: [PATCH 06/43] KVM: x86: Properly reset MMU context at vCPU RESET/INIT · Sean Christopherson <seanjc@google.com> · 2021-05-18
Re: [PATCH 06/43] KVM: x86: Properly reset MMU context at vCPU RESET/INIT · Reiji Watanabe <hidden> · 2021-05-18
Re: [PATCH 06/43] KVM: x86: Properly reset MMU context at vCPU RESET/INIT · Sean Christopherson <seanjc@google.com> · 2021-05-19
Re: [PATCH 06/43] KVM: x86: Properly reset MMU context at vCPU RESET/INIT · Reiji Watanabe <hidden> · 2021-05-24
[PATCH 07/43] KVM: VMX: Remove explicit MMU reset in enter_rmode() · Sean Christopherson <seanjc@google.com> · 2021-04-24
[PATCH 09/43] KVM: SVM: Drop a redundant init_vmcb() from svm_create_vcpu() · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 09/43] KVM: SVM: Drop a redundant init_vmcb() from svm_create_vcpu() · Reiji Watanabe <hidden> · 2021-05-19
[PATCH 08/43] KVM: SVM: Drop explicit MMU reset at RESET/INIT · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 08/43] KVM: SVM: Drop explicit MMU reset at RESET/INIT · Reiji Watanabe <hidden> · 2021-05-19
[PATCH 10/43] KVM: VMX: Move init_vmcs() invocation to vmx_vcpu_reset() · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 10/43] KVM: VMX: Move init_vmcs() invocation to vmx_vcpu_reset() · Reiji Watanabe <hidden> · 2021-05-19
[PATCH 11/43] KVM: x86: WARN if the APIC map is dirty without an in-kernel local APIC · Sean Christopherson <seanjc@google.com> · 2021-04-24
[PATCH 12/43] KVM: x86: Remove defunct BSP "update" in local APIC reset · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 12/43] KVM: x86: Remove defunct BSP "update" in local APIC reset · Reiji Watanabe <hidden> · 2021-05-26
[PATCH 13/43] KVM: x86: Migrate the PIT only if vcpu0 is migrated, not any BSP · Sean Christopherson <seanjc@google.com> · 2021-04-24
[PATCH 14/43] KVM: x86: Don't force set BSP bit when local APIC is managed by userspace · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 14/43] KVM: x86: Don't force set BSP bit when local APIC is managed by userspace · Reiji Watanabe <hidden> · 2021-05-26
[PATCH 15/43] KVM: x86: Set BSP bit in reset BSP vCPU's APIC base by default · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 15/43] KVM: x86: Set BSP bit in reset BSP vCPU's APIC base by default · Reiji Watanabe <hidden> · 2021-05-26
[PATCH 16/43] KVM: VMX: Stuff vcpu->arch.apic_base directly at vCPU RESET · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 16/43] KVM: VMX: Stuff vcpu->arch.apic_base directly at vCPU RESET · Reiji Watanabe <hidden> · 2021-05-26
[PATCH 17/43] KVM: x86: Open code necessary bits of kvm_lapic_set_base() at vCPU RESET · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 17/43] KVM: x86: Open code necessary bits of kvm_lapic_set_base() at vCPU RESET · Reiji Watanabe <hidden> · 2021-05-26
Re: [PATCH 17/43] KVM: x86: Open code necessary bits of kvm_lapic_set_base() at vCPU RESET · Sean Christopherson <seanjc@google.com> · 2021-05-26
[PATCH 18/43] KVM: x86: Consolidate APIC base RESET initialization code · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 18/43] KVM: x86: Consolidate APIC base RESET initialization code · Reiji Watanabe <hidden> · 2021-05-26
[PATCH 19/43] KVM: x86: Move EDX initialization at vCPU RESET to common code · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 19/43] KVM: x86: Move EDX initialization at vCPU RESET to common code · Reiji Watanabe <hidden> · 2021-05-19
[PATCH 20/43] KVM: SVM: Don't bother writing vmcb->save.rip at vCPU RESET/INIT · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 20/43] KVM: SVM: Don't bother writing vmcb->save.rip at vCPU RESET/INIT · Reiji Watanabe <hidden> · 2021-05-19
[PATCH 21/43] KVM: VMX: Invert handling of CR0.WP for EPT without unrestricted guest · Sean Christopherson <seanjc@google.com> · 2021-04-24
[PATCH 22/43] KVM: VMX: Remove direct write to vcpu->arch.cr0 during vCPU RESET/INIT · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 22/43] KVM: VMX: Remove direct write to vcpu->arch.cr0 during vCPU RESET/INIT · Reiji Watanabe <hidden> · 2021-05-19
[PATCH 23/43] KVM: VMX: Fold ept_update_paging_mode_cr0() back into vmx_set_cr0() · Sean Christopherson <seanjc@google.com> · 2021-04-24
[PATCH 24/43] KVM: nVMX: Do not clear CR3 load/store exiting bits if L1 wants 'em · Sean Christopherson <seanjc@google.com> · 2021-04-24
[PATCH 25/43] KVM: VMX: Pull GUEST_CR3 from the VMCS iff CR3 load exiting is disabled · Sean Christopherson <seanjc@google.com> · 2021-04-24
[PATCH 26/43] KVM: VMX: Process CR0.PG side effects after setting CR0 assets · Sean Christopherson <seanjc@google.com> · 2021-04-24
[PATCH 27/43] KVM: VMX: Skip emulation required checks during pmode/rmode transitions · Sean Christopherson <seanjc@google.com> · 2021-04-24
[PATCH 28/43] KVM: nVMX: Don't evaluate "emulation required" on VM-Exit · Sean Christopherson <seanjc@google.com> · 2021-04-24
[PATCH 29/43] KVM: SVM: Tweak order of cr0/cr4/efer writes at RESET/INIT · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 29/43] KVM: SVM: Tweak order of cr0/cr4/efer writes at RESET/INIT · Reiji Watanabe <hidden> · 2021-05-19
Re: [PATCH 29/43] KVM: SVM: Tweak order of cr0/cr4/efer writes at RESET/INIT · Sean Christopherson <seanjc@google.com> · 2021-05-19
Re: [PATCH 29/43] KVM: SVM: Tweak order of cr0/cr4/efer writes at RESET/INIT · Reiji Watanabe <hidden> · 2021-05-23
[PATCH 30/43] KVM: SVM: Drop redundant writes to vmcb->save.cr4 at RESET/INIT · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 30/43] KVM: SVM: Drop redundant writes to vmcb->save.cr4 at RESET/INIT · Reiji Watanabe <hidden> · 2021-05-19
[PATCH 31/43] KVM: SVM: Stuff save->dr6 at during VMSA sync, not at RESET/INIT · Sean Christopherson <seanjc@google.com> · 2021-04-24
[PATCH 32/43] KVM: VMX: Skip pointless MSR bitmap update when setting EFER · Sean Christopherson <seanjc@google.com> · 2021-04-24
[PATCH 33/43] KVM: VMX: Refresh list of user return MSRs after setting guest CPUID · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 33/43] KVM: VMX: Refresh list of user return MSRs after setting guest CPUID · Reiji Watanabe <hidden> · 2021-05-19
[PATCH 34/43] KVM: VMX: Don't _explicitly_ reconfigure user return MSRs on vCPU INIT · Sean Christopherson <seanjc@google.com> · 2021-04-24
[PATCH 35/43] KVM: x86: Move setting of sregs during vCPU RESET/INIT to common x86 · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 35/43] KVM: x86: Move setting of sregs during vCPU RESET/INIT to common x86 · Reiji Watanabe <hidden> · 2021-05-17
Re: [PATCH 35/43] KVM: x86: Move setting of sregs during vCPU RESET/INIT to common x86 · Sean Christopherson <seanjc@google.com> · 2021-05-18
Re: [PATCH 35/43] KVM: x86: Move setting of sregs during vCPU RESET/INIT to common x86 · Reiji Watanabe <hidden> · 2021-05-21
[PATCH 36/43] KVM: VMX: Remove obsolete MSR bitmap refresh at vCPU RESET/INIT · Sean Christopherson <seanjc@google.com> · 2021-04-24
[PATCH 37/43] KVM: nVMX: Remove obsolete MSR bitmap refresh at nested transitions · Sean Christopherson <seanjc@google.com> · 2021-04-24
[PATCH 38/43] KVM: VMX: Don't redo x2APIC MSR bitmaps when userspace filter is changed · Sean Christopherson <seanjc@google.com> · 2021-04-24
[PATCH 39/43] KVM: VMX: Remove unnecessary initialization of msr_bitmap_mode · Sean Christopherson <seanjc@google.com> · 2021-04-24
[PATCH 40/43] KVM: VMX: Smush x2APIC MSR bitmap adjustments into single function · Sean Christopherson <seanjc@google.com> · 2021-04-24
[PATCH 41/43] KVM: VMX: Remove redundant write to set vCPU as active at RESET/INIT · Sean Christopherson <seanjc@google.com> · 2021-04-24
[PATCH 42/43] KVM: VMX: Drop VMWRITEs to zero fields at vCPU RESET · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 42/43] KVM: VMX: Drop VMWRITEs to zero fields at vCPU RESET · Paolo Bonzini <pbonzini@redhat.com> · 2021-05-24
Re: [PATCH 42/43] KVM: VMX: Drop VMWRITEs to zero fields at vCPU RESET · Jim Mattson <hidden> · 2021-05-24
Re: [PATCH 42/43] KVM: VMX: Drop VMWRITEs to zero fields at vCPU RESET · Sean Christopherson <seanjc@google.com> · 2021-05-24
Re: [PATCH 42/43] KVM: VMX: Drop VMWRITEs to zero fields at vCPU RESET · Jim Mattson <hidden> · 2021-05-24
Re: [PATCH 42/43] KVM: VMX: Drop VMWRITEs to zero fields at vCPU RESET · Sean Christopherson <seanjc@google.com> · 2021-05-25
[PATCH 43/43] KVM: x86: Drop pointless @reset_roots from kvm_init_mmu() · Sean Christopherson <seanjc@google.com> · 2021-04-24
Re: [PATCH 43/43] KVM: x86: Drop pointless @reset_roots from kvm_init_mmu() · Sean Christopherson <seanjc@google.com> · 2021-05-27
Re: [PATCH 43/43] KVM: x86: Drop pointless @reset_roots from kvm_init_mmu() · Sean Christopherson <seanjc@google.com> · 2021-05-27
Re: [PATCH 00/43] KVM: x86: vCPU RESET/INIT fixes and consolidation · Paolo Bonzini <pbonzini@redhat.com> · 2021-06-10
Re: [PATCH 00/43] KVM: x86: vCPU RESET/INIT fixes and consolidation · Sean Christopherson <seanjc@google.com> · 2021-06-10

From: Reiji Watanabe <hidden>
Date: 2021-05-19 05:42:13
Also in: lkml

On Fri, Apr 23, 2021 at 5:54 PM Sean Christopherson [off-list ref] wrote:

Drop direct writes to vmcb->save.cr4 during vCPU RESET/INIT, as the
values being written are fully redundant with respect to
svm_set_cr4(vcpu, 0) a few lines earlier.  Note, svm_set_cr4() also
correctly forces X86_CR4_PAE when NPT is disabled.

No functional change intended.

Signed-off-by: Sean Christopherson <seanjc@google.com>

Reviewed-by: Reiji Watanabe <redacted>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help