Re: [PATCH 03/15] KVM: selftests: Align HVA for HugeTLB-backed memslots
From: Ben Gardon <hidden>
Date: 2021-02-11 00:57:22
Also in:
lkml
On Wed, Feb 10, 2021 at 3:06 PM Sean Christopherson [off-list ref] wrote:
Align the HVA for HugeTLB memslots, not just THP memslots. Add an assert so any future backing types are forced to assess whether or not they need to be aligned. Cc: Ben Gardon <redacted> Cc: Yanan Wang <redacted> Cc: Andrew Jones <redacted> Cc: Peter Xu <peterx@redhat.com> Cc: Aaron Lewis <redacted> Signed-off-by: Sean Christopherson <seanjc@google.com>
Reviewed-by: Ben Gardon <redacted>
quoted hunk ↗ jump to hunk
--- tools/testing/selftests/kvm/lib/kvm_util.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c index 584167c6dbc7..deaeb47b5a6d 100644 --- a/tools/testing/selftests/kvm/lib/kvm_util.c +++ b/tools/testing/selftests/kvm/lib/kvm_util.c@@ -731,8 +731,11 @@ void vm_userspace_mem_region_add(struct kvm_vm *vm, alignment = 1; #endif - if (src_type == VM_MEM_SRC_ANONYMOUS_THP) + if (src_type == VM_MEM_SRC_ANONYMOUS_THP || + src_type == VM_MEM_SRC_ANONYMOUS_HUGETLB) alignment = max(huge_page_size, alignment); + else + ASSERT_EQ(src_type, VM_MEM_SRC_ANONYMOUS); /* Add enough memory to align up if necessary */ if (alignment > 1) --2.30.0.478.g8a0d178c01-goog