Thread (32 messages) 32 messages, 7 authors, 2021-02-23

Re: [PATCH v2 03/11] hw/core: Restrict 'query-machines' to those supported by current accel

From: Cornelia Huck <cohuck@redhat.com>
Date: 2021-02-22 17:49:49
Also in: qemu-arm, qemu-devel, xen-devel

On Fri, 19 Feb 2021 18:38:39 +0100
Philippe Mathieu-Daudé [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Do not let 'query-machines' return machines not valid with
the current accelerator.

Suggested-by: Daniel Berrangé <redacted>
Signed-off-by: Philippe Mathieu-Daudé <redacted>
---
 hw/core/machine-qmp-cmds.c | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c
index 44e979e503b..c8630bc2ddc 100644
--- a/hw/core/machine-qmp-cmds.c
+++ b/hw/core/machine-qmp-cmds.c
@@ -204,6 +204,10 @@ MachineInfoList *qmp_query_machines(Error **errp)
         MachineClass *mc = el->data;
         MachineInfo *info;
 
+        if (!machine_class_valid_for_current_accelerator(mc)) {
+            continue;
+        }
+
         info = g_malloc0(sizeof(*info));
         if (mc->is_default) {
             info->has_is_default = true;
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help